Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: spr - Statistical pattern recognition https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227579 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-04-22 03:24 EST ------- For 05.01.00-1: * rpmlint - attached Summary: - libSPR.so.0.0.0 contains undefined non-weak symbols. This is a BLOCKER for the rpm providing -devel subpackage because linkage against this library fais due to these symbols. * Timestamps - This package installs many text files (such as header files) which are not modified during build stage and keeping timestamps on these files are highly recommended. For this package, the following works. ----------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -c -p" ----------------------------------------------------- * header files location - Generally, if a package installs "many" header files, their header files should be hidden in the package specific directory to aboid namespace conflict. Would you consider to move all header files to under %{_includedir}/%{name}/ ? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review