https://bugzilla.redhat.com/show_bug.cgi?id=1111294 --- Comment #6 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- Additionally: What's the origin of Source1: engrid.png? I can see that the included setup_fedora.bash script uses src/libengrid/resources/icons/G.png, so why not do the same instead of shipping another copy in the SRPM? The engrid_build.patch contains whitespace-only change, which should be dropped to improve readability, namely this part (changes to src/engrid.pro.app): @ -46,11 +46,12 @@ win32-msvc* { LIBS += ../../netCDF/lib/netcdfcxx.lib } } else { - QMAKE_CXXFLAGS += -Wno-deprecated -g + CONFIG += link_pkgconfig + QMAKE_CXXFLAGS += -Wno-deprecated -g INCLUDEPATH += $(VTKINCDIR) LIBS += -L$(VTKLIBDIR) - LIBS += -L./netgen_svn -lng LIBS += -L./libengrid -lengrid + PKGCONFIG += netgen-mesher brlcad { INCLUDEPATH += $(BRLCADINCDIR) INCLUDEPATH += $(BRLCADINCDIR)/openNURBS You can skip adjusting formatting of the QMAKE_CXXFLAGS line. rpmlint issues: engrid.x86_64: W: incoherent-version-in-changelog 1.4-1 ['1.4.0-1.gite6d55f5.fc20', '1.4.0-1.gite6d55f5'] -> easyfix engrid.x86_64: W: shared-lib-calls-exit /usr/lib64/libengrid.so.1.0.0 exit@GLIBC_2.2.5 -> please report upstream engrid.x86_64: W: undefined-non-weak-symbol /usr/lib64/libengrid.so.1.0.0 nc_put_vara_short [...] engrid.x86_64: W: undefined-non-weak-symbol /usr/lib64/libengrid.so.1.0.0 nc_inq_var engrid.x86_64: W: undefined-non-weak-symbol /usr/lib64/libengrid.so.1.0.0 typeinfo for vtkInteractorStyle [...] -> looks like missing libraries during linking stage engrid.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libengrid.so.1.0.0 /lib64/libQtNetwork.so.4 -> drop from link flags Source checksums ---------------- https://github.com/enGits/engrid/tarball/e6d55f564c20a8d13bee6bba6280a32320f1bde2/enGits-engrid-1.4.0-264-ge6d55f5.tar.gz : CHECKSUM(SHA256) this package : 27119148fbcefe8654c213bdeb503bec323bd5a72181dd17ae8035492e80cc26 CHECKSUM(SHA256) upstream package : 27119148fbcefe8654c213bdeb503bec323bd5a72181dd17ae8035492e80cc26 Licence seems to be ok, but there are some files without licence information: src/dialoglineedit/* Please ask upstream to clarify the licence on those. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review