Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-HTML-CalendarMonthSimple - Perl Module for Generating HTML Calendars https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232623 ------- Additional Comments From cweyl@xxxxxxxxxxxxxxx 2007-04-21 23:14 EST ------- Missing a BR on perl(Date::Calc). + source files match upstream: 2f9fcad2627890cc11ab5c3cd3c986cf HTML-CalendarMonthSimple-1.25.tar.gz 2f9fcad2627890cc11ab5c3cd3c986cf ../HTML-CalendarMonthSimple-1.25.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. License text included in package. (Entire license grant is in README & CalendarMonthSimple.pm) + latest version is being packaged. X BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package installs properly O noarch -- no debuginfo package + rpmlint is silent. + final provides and requires are sane: ** perl-HTML-CalendarMonthSimple-1.25-1.fc6.noarch.rpm == rpmlint == provides perl(HTML::CalendarMonthSimple) perl-HTML-CalendarMonthSimple = 1.25-1.fc6 == requires perl(:MODULE_COMPAT_5.8.8) perl(Date::Calc) perl(strict) + %check is present and all tests pass + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app. Add perl(Date::Calc) -- post-import -- and the package is: APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review