https://bugzilla.redhat.com/show_bug.cgi?id=975266 Lubomir Rintel <lkundrak@xxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tibbs@xxxxxxxxxxx |lkundrak@xxxxx --- Comment #8 from Lubomir Rintel <lkundrak@xxxxx> --- Stealing this from Jason since he does not respond. 0.) The package naming and versioning As you pointed out, the number in the file name is not a version. The package should be named cmap-japan1-6; the question what to take for the version remains open (as only the mappings themselves seem to be versioned separately). I suggest you either contact upstream and ask for their advice on packaging/versioning, or use the modification date, such as 20120814 or 2012.08.14 for version. 1.) I'm not sure you need to include the two documentation files Licensing information is embedded in the files themselves and these two files seem to change upstream; we'd need to figure out how to package them then. 2.) This is unnecessary: mkdir -p %{buildroot}%{_docdir}/cmap/%{name}-%{version} 3.) These belong in %prep (unless you decide to drop them as I suggested): mkdir _tmpdoc install -p -m0644 %SOURCE1 %SOURCE2 _tmpdoc Also, "rm -rf _tmpdoc" is unnecessary. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review