[Bug 1114212] Review Request: glite-lb-server - gLite Logging and Bookkeeping server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1114212



--- Comment #3 from František Dvořák <valtri@xxxxxxxxxx> ---
(In reply to Christopher Meng from comment #2)
> 
> [-]: Package must own all directories that it creates.
>      Note: Directories without known owners: /etc/logrotate.d

I've added logrotate to requires yet.


> 1. Why so many 755 dirs? Can't 750 satisfy?
> 

It looks like rpmlint is not happy about that:

glite-lb-server.x86_64: E: non-standard-dir-perm /var/spool/glite 0750L

Do you think I should limit the permissions anyway? The files created by gLite
daemons in /var/spool/glite have 0600 permissions, so additional listing
permissions on directory couldn't be a problem...


> 2. install -m 0644 ChangeLog LICENSE %{buildroot}%{_pkgdocdir}
> 
> Why not %doc?
> 

It is due to EPEL support. There is something installed in /usr/share/doc
already by 'make install' and EPEL 6 doesn't handle combination of already
existing files and %doc very well.


> 3. Missing Requires(pre): shadow-utils
> 

Good catch.


> Hint: make install DESTDIR=%{buildroot} = %make_install
> 
> F21+ make %{?_smp_mflags} = %make_build

I would rather keep the old-school "chatty" version here. :-) It is also needed
for EPEL 5.


New version:

Spec URL:
http://scientific.zcu.cz/fedora/glite-lb-server-3.0.18-2/glite-lb-server.spec
SRPM URL:
http://scientific.zcu.cz/fedora/glite-lb-server-3.0.18-2/glite-lb-server-3.0.18-2.fc22.src.rpm

* Tue Jul 29 2014 František Dvořák <valtri@xxxxxxxxxx> - 3.0.18-2
- Added logrotate and shadow-utils requires
- Minimal requirements for glite-lbjp-common-server-bones not needed in EPEL

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]