[Bug 1076976] Review Request: rubygem-settingslogic - Simple settings solution for Ruby

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1076976



--- Comment #7 from František Dvořák <valtri@xxxxxxxxxx> ---
(In reply to Josef Stribny from comment #6)
> > Yes, it is, except EPEL6. Moved rspec-core BR into sl6 macro block.
> 
> Try not to get lost in all those macros. Sometimes it's better to have
> different specs in more branches as the specs with a lot of conditionals
> cannot be easily upgraded by automatic scripts/tools and might be difficult
> for packagers doing OS wide fixes to deal with. But that's just up to you.
> 

True, I've already though about separating at least the EPEL6 changes... I'll
probably throw all the differences to the branches, there will be also the
%check exception for EPEL7.

> As this gem doesn't have any C extension I would probably remove the gem2rpm
> comment as misleading. Otherwise the fixes has been made, the package
> builds, installs, runs ==> APPROVING.

OK. Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]