[Bug 1076976] Review Request: rubygem-settingslogic - Simple settings solution for Ruby

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1076976



--- Comment #5 from František Dvořák <valtri@xxxxxxxxxx> ---
(In reply to Josef Stribny from comment #4)
> > BuildRequires:  rubygem(rspec)
> > BuildRequires:  rubygem(rspec-core)
> 
> Requiring rspec-core here is redundant as its a dependency of rspec.
> 

Yes, it is, except EPEL6. Moved rspec-core BR into sl6 macro block.

(and there will be needed to disable checks, if adding to EPEL7 branch - there
is no rubygem(rspec-core) yet)


> > # Remove developer-only files.
> > for f in .gitignore Gemfile Gemfile.lock README.rdoc Rakefile; do
> 
> You sure can remove files used only for development, but README.rdoc is part
> of the documentation and as such should be placed in -doc subpackage and
> marked as %doc.

Didn't catch that, thanks.


Spec URL:
http://scientific.zcu.cz/fedora/rubygem-settingslogic-2.0.9-3/rubygem-settingslogic.spec
SRPM URL:
http://scientific.zcu.cz/fedora/rubygem-settingslogic-2.0.9-3/rubygem-settingslogic-2.0.9-3.fc22.src.rpm

* Mon Jul 28 2014 František Dvořák <valtri@xxxxxxxxxx> - 2.0.9-3
- Added README.rdoc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]