[Bug 1036755] Review Request: python-httpretty - HTTP client mock for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1036755

Miro Hrončok <mhroncok@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(dridi.boukelmoune |
                   |@gmail.com)                 |
                   |needinfo?(mhroncok@redhat.c |
                   |om)                         |



--- Comment #27 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
Quick spec look:

> 0%{?fedora} > 12

Is that really necessary after almost ten releases?

> Patch0:         0001-Replace-unicode-character-with-ASCII.patch
> Patch1:         0002-Un-pin-requirements.patch

Those should have comments and/or upstream links.

> %package -n python3-httpretty
> Summary:        HTTP request mock tool for Python

I'd suggest to change it to:

HTTP request mock tool for Python 3

Also maybe drop a comment about missing %check section that links to your
previous comment, or even better: keep the %check there but hide it by a
condition.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]