https://bugzilla.redhat.com/show_bug.cgi?id=1121085 --- Comment #2 from Josef Stribny <jstribny@xxxxxxxxxx> --- > I've noticed the development files (Rakefile, Gemfile, ...) are in -doc > subpackage. I guess this is up to packager, what to do with the files? Or is > there any recommendation? This is tricky. As you say it's up to the packager which makes creating additional tooling quite a pain. I would actually like it to be a standard. What I do is that if upstream ships something in .gem, I include it as well (in -doc if it's not for runtime) expect for dot files. Your way is also completely ok for current guidelines. > 1) the spec file is different from .src.rpm I am sorry for that, the spec is newer. > 2) W: macro-in-comment %check (line 58) As you said, it's already fixed. > 3) extra spaces at end of lines 13 and 25 :-) Oh yes, we need to fix it soon in gem2rpm, Fixed. > 4) * E: script-without-shebang /usr/share/gems/gems/pundit-0.2.3/lib/generators/pundit/policy/templates/policy.rb > I guess this file should not be executable? True, good catch, fixed. > Could you review swap for #1076976 rubygem-settingslogic? Sure thing! Spec URL: http://data-strzibny.rhcloud.com/obs/rubygem-pundit.spec SRPM URL: http://data-strzibny.rhcloud.com/obs/rubygem-pundit-0.2.3-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review