[Bug 1123689] Review Request: yadifa - Lightweight authoritative Name Server with DNSSEC capabilities

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1123689



--- Comment #1 from Denis Fateyev <denis@xxxxxxxxxxx> ---
Note: rpmlint reports an error "E: missing-call-to-setgroups /usr/sbin/yadifad"
caused by missing `initgroups` or `setgroups` call in function in
`sbin/yadifad/main.c` file:

static void
change_identity(config_data *config)
{
    uid_t uid = getuid();
    gid_t gid = getgid();
    log_info("changing identity to %d:%d (current: %d:%d)", config->uid,
config->gid, uid, gid);

    if(gid != config->gid)
    {    
        Setgid(config->gid);
    }
    if(uid != config->uid)
    {
        Setuid(config->uid);
    }
}

I think it's not critical since the proper setuid() / setgid() calling order is
used here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]