https://bugzilla.redhat.com/show_bug.cgi?id=1123511 --- Comment #2 from Michael Schwendt <bugs.michael@xxxxxxx> --- A couple of minor issues: > BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) > %defattr(-,root,root) > %clean > rm -fR %{buildroot} These are only needed for EL5, so unless you want to build for EL5, consider dropping them: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean > %if %{with static} > %configure --enable-doc --enable-debug --enable-static > %else > %configure --enable-doc --enable-debug --disable-static > %endif IMO, the following would be smarter (since you would not need to modify two %configure calls whenever you wanted to change the options): %configure --enable-doc --enable-debug \ %{?_with_static:--enable-static}%{!?_with_static:--disable-static} > make %{?_smp_mflags} The build.log output is non-verbose (=silent). One cannot see which preprocessor/compiler flags and parameters are active. One work-around would be to call the configure script with option --disable-silent-rules, another would be to call make with V=1. Doing that, it turns out the package is built without Fedora's global flags: https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags > %files devel > %doc ChangeLog COPYING README > %files utils > %doc ChangeLog COPYING README Both subpackages don't need to duplicate these %doc files, because they (unlike the -doc subpkg) depend on the base package already. Plus, note that many users prefer changelog files to be included in the base runtime package anyway. > %{_libdir}/pkgconfig/*.pc Umm, ... it says "Version: 2.0.2" which is neither the package %version (0.4 beta) nor the lib SONAME version (0, 0.2.0). Anything known about this confusing versioning? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review