[Bug 1122229] Review Request: nodejs-pac-resolver - Generates an asynchronous resolver function from a PAC file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1122229

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ mock build is successful for f22.

+ rpmlint output on rpms gave
nodejs-pac-resolver.noarch: W: only-non-binary-in-usr-lib
nodejs-pac-resolver.noarch: W: dangling-symlink
/usr/lib/node_modules/pac-resolver/node_modules/netmask
/usr/lib/node_modules/netmask
nodejs-pac-resolver.noarch: W: dangling-symlink
/usr/lib/node_modules/pac-resolver/node_modules/co /usr/lib/node_modules/co
nodejs-pac-resolver.noarch: W: dangling-symlink
/usr/lib/node_modules/pac-resolver/node_modules/degenerator
/usr/lib/node_modules/degenerator
nodejs-pac-resolver.noarch: W: dangling-symlink
/usr/lib/node_modules/pac-resolver/node_modules/thunkify
/usr/lib/node_modules/thunkify
nodejs-pac-resolver.noarch: W: dangling-symlink
/usr/lib/node_modules/pac-resolver/node_modules/regenerator
/usr/lib/node_modules/regenerator
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball    
:36b89f56be08f406dbee837de8cd1537bcfcd5e805e9d0a9a32b19cc0bccafbc
upstream tarball
:36b89f56be08f406dbee837de8cd1537bcfcd5e805e9d0a9a32b19cc0bccafbc

+ License "MIT" is valid and is included in its README.md file as %doc

+ rest looks following packaging guidelines.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]