[Bug 1119947] Review Request: makepp - Compatible but reliable and improved replacement for make

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1119947



--- Comment #3 from Michael Schwendt <bugs.michael@xxxxxxx> ---
A quick look at the spec file:


> %doc

To be deleted. An empty %doc line makes no sense. It's a no-op.


> %{_bindir}/*

Sort of sloppy packaging, because this would include anything in the package
and would even accept a missing %{_bindir}/%{name} executable. Please be a
little more explicit about which files to include, also to increase
clearness/comprehensibility of the spec file. A compromise would be to do

  %{_bindir}/%{name}*
  %{_bindir}/mpp*

with the caveat that it would also not fail for an absent %{_bindir}/%{name}
file (or other files people expect to be available). Ideal would be to either
spell out all files you never want to be missing, or to add a guard that
verifies whether e.g. %{buildroot}%{_bindir}/%{name} is available. The %install
or %check section is suitable for that.


> %{_mandir}/*

Here the brevity leads to including too many subdirs of %{_mandir}, which
belong into the "filesystem" package already and must not be included in your
package:

https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership


> %{_datadir}/makepp/*
> %{_defaultdocdir}/makepp/*

https://fedoraproject.org/wiki/Packaging:UnownedDirectories

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]