[Bug 1122224] Review Request: nodejs-get-uri - Returns a stream.Readable from a URI string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1122224

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ mock build is successful for f22.

+ rpmlint output on rpms gave
nodejs-get-uri.noarch: W: only-non-binary-in-usr-lib
nodejs-get-uri.noarch: W: dangling-symlink
/usr/lib/node_modules/get-uri/node_modules/ftp /usr/lib/node_modules/ftp
nodejs-get-uri.noarch: W: dangling-symlink
/usr/lib/node_modules/get-uri/node_modules/data-uri-to-buffer
/usr/lib/node_modules/data-uri-to-buffer
nodejs-get-uri.noarch: W: dangling-symlink
/usr/lib/node_modules/get-uri/node_modules/readable-stream
/usr/lib/node_modules/readable-stream
nodejs-get-uri.noarch: W: dangling-symlink
/usr/lib/node_modules/get-uri/node_modules/extend /usr/lib/node_modules/extend
nodejs-get-uri.noarch: W: dangling-symlink
/usr/lib/node_modules/get-uri/node_modules/file-uri-to-path
/usr/lib/node_modules/file-uri-to-path
nodejs-get-uri.noarch: W: dangling-symlink
/usr/lib/node_modules/get-uri/node_modules/debug /usr/lib/node_modules/debug
2 packages and 0 specfiles checked; 0 errors, 7 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball    
:8c4a80ce4fbb65aee1f9b054afd2a7dbcabc300eac08f60d8e6d0e811cba4e9c
upstream tarball
:8c4a80ce4fbb65aee1f9b054afd2a7dbcabc300eac08f60d8e6d0e811cba4e9c

+ License "MIT" is valid and is included in its README.md file as %doc

+ rest looks following packaging guidelines.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]