Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pgpool-ha : Pgpool-HA uses heartbeat to keep pgpool from being a single point of failure https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229322 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|normal |medium ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-04-20 19:36 EST ------- 1. the date of the newest entry in %changelog is obviously wrong, since it was modified 2007-04-18, not Oct 10 2006 2. I fail to understand why is the same file included twice (see install -m 755 pgpool %{buildroot}%{_sysconfdir}/ha.d/resource.d/heartbeat/pgpool install -m 755 pgpool %{buildroot}%{_libdir}/ocf/resource.d/heartbeat/) You could symlink it if you really need it twice 3. Installing files under %{_libdir} prevents the package from being noarch 4. I did not actually test because postgresql-pgpool-II has not yet been pushed, but from looking at the spec I'd say that the %build step should include a make, while %install should include a "make install". In the current version of the spec, the actual build seems to take place in %install. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review