https://bugzilla.redhat.com/show_bug.cgi?id=1121988 --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review: + mock build is successful for f22. + rpmlint output on rpms gave zanata-python-client.noarch: E: explicit-lib-dependency python-hashlib zanata-python-client.noarch: E: incorrect-fsf-address /usr/bin/flies zanata-python-client.noarch: W: no-manual-page-for-binary flies zanata-python-client.noarch: W: no-manual-page-for-binary zanata zanata-python-client.src:179: W: macro-in-%changelog %doc 2 packages and 0 specfiles checked; 2 errors, 3 warnings. + Source verified with upstream as (sha256sum) srpm tarball :9cbc8cacc3f86327e2a2aa902cd8215df3964dc23b395043338d75460aebd77b upstream tarball :9cbc8cacc3f86327e2a2aa902cd8215df3964dc23b395043338d75460aebd77b + License "MIT" is valid and is included in its own file as %doc + rest looks following packaging guidelines. Suggestions: 1) Ask upstream to fix the fsf address in /usr/bin/flies 2) every '%' character in changelog should be written as '%%' 3) you don't need sitelib macro for current Fedora releases %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")} drop above. 4) Drop Group tag 5) Instead of following %if 0%{?fedora} < 13 BuildRequires: python-devel %endif just add BuildRequires: python2-devel we want this BR: for python packages 6) Change %{__python} to %{__python2} 7) drop %clean 8) change %{python_sitelib} to %{python2_sitelib} 9) drop defattr line Check more on http://fedoraproject.org/wiki/Packaging:Python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review