[Bug 1122234] Review Request: nodejs-recast - JavaScript syntax tree transformer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1122234

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ mock build is successful for f22.

+ rpmlint output on rpms gave
nodejs-recast.noarch: W: only-non-binary-in-usr-lib
nodejs-recast.noarch: W: dangling-symlink
/usr/lib/node_modules/recast/node_modules/cls /usr/lib/node_modules/cls
nodejs-recast.noarch: W: dangling-symlink
/usr/lib/node_modules/recast/node_modules/private /usr/lib/node_modules/private
nodejs-recast.noarch: W: dangling-symlink
/usr/lib/node_modules/recast/node_modules/esprima /usr/lib/node_modules/esprima
nodejs-recast.noarch: W: dangling-symlink
/usr/lib/node_modules/recast/node_modules/ast-types
/usr/lib/node_modules/ast-types
nodejs-recast.noarch: W: dangling-symlink
/usr/lib/node_modules/recast/node_modules/source-map
/usr/lib/node_modules/source-map
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball    
:bbd406d310400d27c00bd6575faf59b6f0ab6596ddba6b2650d1d243185f271f
upstream tarball
:bbd406d310400d27c00bd6575faf59b6f0ab6596ddba6b2650d1d243185f271f

+ License "MIT" is valid and is included in its own file as %doc

+ rest looks following packaging guidelines.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]