https://bugzilla.redhat.com/show_bug.cgi?id=1113392 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #6 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review: + mock build is successful for f22. + rpmlint output on rpms gave 3 packages and 0 specfiles checked; 0 errors, 0 warnings. + Source verified with upstream as (sha256sum) srpm tarball :3737be379af423833d4a258c9d0dd174e21c9c94550f18bcc2224dcd9e16c5ac upstream tarball :3737be379af423833d4a258c9d0dd174e21c9c94550f18bcc2224dcd9e16c5ac + License "MIT" is valid and is included in its own COPYING file as %doc + Package xorg-x11-drv-libinput-0.1.2-1.fc22.x86_64 => Provides: libinput_drv.so()(64bit) xorg-x11-drv-libinput = 0.1.2-1.fc22 xorg-x11-drv-libinput(x86-64) = 0.1.2-1.fc22 Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.4)(64bit) libc.so.6(GLIBC_2.7)(64bit) libinput.so.3()(64bit) rtld(GNU_HASH) Suggestions: 1) for upstream: fedora-review said AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: xf86-input-libinput-xf86-input- libinput-0.1.2/configure.ac:38 good to ask upstream to fix this. 2) Group tag is now optional and you can drop this for Fedora. 3) You may want to fix empty characters in first line of %prep 4) all install or cp commands should preserve timestamp http://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps Please fix above issues before package import. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review