[Bug 1122248] Review Request: nodejs-yargs - Light-weight option parsing with an argv hash.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1122248

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ mock build is successful for f22.

- rpmlint output on rpms gave
nodejs-yargs.noarch: W: spelling-error Summary(en_US) argv -> Argo
nodejs-yargs.noarch: W: summary-ended-with-dot C Light-weight option parsing
with an argv hash.
nodejs-yargs.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-yargs.noarch: W: spelling-error %description -l en_US tryin -> trying,
train, tr yin
nodejs-yargs.noarch: W: spelling-error %description -l en_US ter -> yer, tee,
tr
nodejs-yargs.noarch: W: spelling-error %description -l en_US optstrings -> opt
strings, opt-strings, striplings
nodejs-yargs.noarch: W: spelling-error %description -l en_US scallywags ->
scalawags, scalawag
nodejs-yargs.noarch: W: spelling-error %description -l en_US lookin -> looking,
loo kin, loo-kin
nodejs-yargs.noarch: W: spelling-error %description -l en_US shipz -> ship,
ships, ship z
nodejs-yargs.noarch: W: spelling-error %description -l en_US thru -> threw,
throe, thrum
nodejs-yargs.noarch: W: spelling-error %description -l en_US disincling ->
disincline, disinclining, disciplining
nodejs-yargs.noarch: W: spelling-error %description -l en_US havin -> having,
haven, Gavin
nodejs-yargs.noarch: W: invalid-license MIT/X11
nodejs-yargs.noarch: W: only-non-binary-in-usr-lib
nodejs-yargs.noarch: W: dangling-symlink
/usr/lib/node_modules/yargs/node_modules/minimist
/usr/lib/node_modules/minimist
nodejs-yargs.src: W: spelling-error Summary(en_US) argv -> Argo
nodejs-yargs.src: W: summary-ended-with-dot C Light-weight option parsing with
an argv hash.
nodejs-yargs.src: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-yargs.src: W: spelling-error %description -l en_US tryin -> trying,
train, tr yin
nodejs-yargs.src: W: spelling-error %description -l en_US ter -> yer, tee, tr
nodejs-yargs.src: W: spelling-error %description -l en_US optstrings -> opt
strings, opt-strings, striplings
nodejs-yargs.src: W: spelling-error %description -l en_US scallywags ->
scalawags, scalawag
nodejs-yargs.src: W: spelling-error %description -l en_US lookin -> looking,
loo kin, loo-kin
nodejs-yargs.src: W: spelling-error %description -l en_US shipz -> ship, ships,
ship z
nodejs-yargs.src: W: spelling-error %description -l en_US thru -> threw, throe,
thrum
nodejs-yargs.src: W: spelling-error %description -l en_US disincling ->
disincline, disinclining, disciplining
nodejs-yargs.src: W: spelling-error %description -l en_US havin -> having,
haven, Gavin
nodejs-yargs.src: W: invalid-license MIT/X11
2 packages and 0 specfiles checked; 0 errors, 28 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball    
:fc41778fadfffb326f662325784b1f2488727c0f8a5e5f27a92c114bf8e7af63
upstream tarball
:fc41778fadfffb326f662325784b1f2488727c0f8a5e5f27a92c114bf8e7af63


+ rest looks following packaging guidelines.

Suggestions:
1) Fix rpmlint warnings
summary-ended-with-dot
invalid-license MIT/X11

>From LICENSE file it looks license tag should be "MIT" only.

I will not block for this review for above issue. Please fix this and then
import the package.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]