[Bug 1122245] Review Request: nodejs-thunkify - Turn callbacks, arrays, generators, and more into thunks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1122245

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ mock build is successful for f22.

+ rpmlint output on rpms gave
nodejs-thunkify.noarch: W: only-non-binary-in-usr-lib
nodejs-thunkify.noarch: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball    
:38308ec23e761e69077652851759db00cf79d43f7830cb99f10c02cfa8b19179
upstream tarball
:38308ec23e761e69077652851759db00cf79d43f7830cb99f10c02cfa8b19179

+ License "MIT" is valid.

+ rest looks following packaging guidelines.

Suggestions:
1) include Readme.md as %doc

2) Ask upstream to provide license text in any way with upstream tarball.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]