[Bug 1122243] Review Request: nodejs-stringset - fast and robust stringset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1122243

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ mock build is successful for f22.

+ rpmlint output on rpms gave
nodejs-stringset.noarch: W: summary-not-capitalized C fast and robust stringset
nodejs-stringset.noarch: W: spelling-error %description -l en_US proto ->
proton, pronto, promo
nodejs-stringset.noarch: W: spelling-error %description -l en_US ss -> SS, sch,
sci
nodejs-stringset.noarch: W: only-non-binary-in-usr-lib
nodejs-stringset.src: W: summary-not-capitalized C fast and robust stringset
nodejs-stringset.src: W: spelling-error %description -l en_US proto -> proton,
pronto, promo
nodejs-stringset.src: W: spelling-error %description -l en_US ss -> SS, sch,
sci
2 packages and 0 specfiles checked; 0 errors, 7 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball    
:4ceffeb46a8c0d554ad3290f213f81b27e02c6dce31331d5f9e3bba89155eefc
upstream tarball
:4ceffeb46a8c0d554ad3290f213f81b27e02c6dce31331d5f9e3bba89155eefc

+ License "MIT" is valid and is included in its own file as %doc

+ rest looks following packaging guidelines.

Suggestions:
1) You may want to fix summary rpmlint warning.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]