[Bug 1122210] Review Request: nodejs-ast-traverse - Simple but flexible AST traversal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1122210

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ mock build is successful for f22

+ rpmlint output on rpms gave
nodejs-ast-traverse.noarch: W: spelling-error %description -l en_US pre -> per,
ore, pee
nodejs-ast-traverse.noarch: W: only-non-binary-in-usr-lib
nodejs-ast-traverse.src: W: spelling-error %description -l en_US pre -> per,
ore, pee
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball    
:66e8417e084d903636d285f2ca269232539f2bbf10cae54de7b7525aec9f5066
upstream tarball
:66e8417e084d903636d285f2ca269232539f2bbf10cae54de7b7525aec9f5066

+ License "MIT" is valid and is included in its own file as %doc

+ rest looks following packaging guidelines

Suggestions:
1) Please remove unnecessary empty lines 4-5

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]