https://bugzilla.redhat.com/show_bug.cgi?id=1121924 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- (In reply to David Dick from comment #3) > (In reply to Jitka Plesnikova from comment #2) > > License is NOT ok > > FIX: In test directory, several files do not have the same license as Perl > > (for more details see Term-ANSIColor-4.03/LICENSE) > > The listed license should add in License tag. > > I don't know the correct shortcut for it and if it is valid license for > > Fedora, > > you can ask Fedora legal. You should also report it to upstream. > > Hi Jitka, > > The Expat license reference is to the license used by the "expat" package. > If you examine the wording between /usr/share/doc/expat/COPYING and the > "License: Expat" section in Term-ANSIColor-4.03/LICENSE, you'll see the > wording is identical. As the License tag only covers the binary RPM, i > don't think that i need to change the License tag either, as the Expat > licensed files all appear to be for the test suite. Is this ok? In that case the license is ok > > > FIX: Remove executable bit from > > /usr/share/doc/perl-Term-ANSIColor/examples/generate-colors > > Add 'chmod -c -x examples/*' to %prep section. It also clean up rpmlint > > warnings 'doc-file-dependency'. > > Done. 28a29 > chmod -c -x examples/* Ok Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review