https://bugzilla.redhat.com/show_bug.cgi?id=1121924 --- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- License is NOT ok FIX: In test directory, several files do not have the same license as Perl (for more details see Term-ANSIColor-4.03/LICENSE) The listed license should add in License tag. I don't know the correct shortcut for it and if it is valid license for Fedora, you can ask Fedora legal. You should also report it to upstream. URL and Source0 are ok Summary and Description are ok Package builds in F22 - http://koji.fedoraproject.org/koji/taskinfo?taskID=7171971 Build-requires are ok $ rpm -qp --provides perl-Term-ANSIColor-4.03-1.fc22.noarch.rpm | sort | uniq -c 1 perl(Term::ANSIColor) = 4.03 1 perl-Term-ANSIColor = 4.03-1.fc22 Binary provides are ok $ rpm -qp --requires perl-Term-ANSIColor-4.03-1.fc22.noarch.rpm | sort | uniq -c 1 /usr/bin/perl 1 perl >= 0:5.006 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(Carp) 1 perl(Exporter) 1 perl(Term::ANSIColor) >= 4.00 1 perl(constant) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are ok $ rpmlint ./perl-Term-ANSIColor* perl-Term-ANSIColor.src: W: spelling-error %description -l en_US uncolor -> uncolored, councilor, uncool perl-Term-ANSIColor.src: W: spelling-error %description -l en_US colorstrip -> color strip, color-strip, colors trip perl-Term-ANSIColor.src: W: spelling-error %description -l en_US colorvalid -> color valid, color-valid, Corvallis perl-Term-ANSIColor.src: W: spelling-error %description -l en_US coloralias -> color alias, color-alias, coloraturas perl-Term-ANSIColor.noarch: W: spelling-error %description -l en_US uncolor -> uncolored, councilor, uncool perl-Term-ANSIColor.noarch: W: spelling-error %description -l en_US colorstrip -> color strip, color-strip, colors trip perl-Term-ANSIColor.noarch: W: spelling-error %description -l en_US colorvalid -> color valid, color-valid, Corvallis perl-Term-ANSIColor.noarch: W: spelling-error %description -l en_US coloralias -> color alias, color-alias, coloraturas perl-Term-ANSIColor.noarch: W: doc-file-dependency /usr/share/doc/perl-Term-ANSIColor/examples/generate-colors /usr/bin/perl perl-Term-ANSIColor.noarch: W: doc-file-dependency /usr/share/doc/perl-Term-ANSIColor/examples/generate-colors perl(constant) 2 packages and 1 specfiles checked; 0 errors, 10 warnings. Rpmlint is ok $ rpm -qp -lv perl-Term-ANSIColor-4.03-1.fc22.noarch.rpm drwxr-xr-x 2 root root 0 Jul 22 12:41 /usr/share/doc/perl-Term-ANSIColor -rw-r--r-- 1 root root 2300 Mar 24 02:41 /usr/share/doc/perl-Term-ANSIColor/LICENSE -rw-r--r-- 1 root root 9293 Mar 24 02:41 /usr/share/doc/perl-Term-ANSIColor/NEWS -rw-r--r-- 1 root root 10062 Mar 24 02:41 /usr/share/doc/perl-Term-ANSIColor/README drwxr-xr-x 2 root root 0 Mar 24 02:41 /usr/share/doc/perl-Term-ANSIColor/examples -rwxr-xr-x 1 root root 8986 Mar 24 02:41 /usr/share/doc/perl-Term-ANSIColor/examples/generate-colors -rw-r--r-- 1 root root 11709 Jul 22 12:41 /usr/share/man/man3/Term::ANSIColor.3pm.gz drwxr-xr-x 2 root root 0 Jul 22 12:41 /usr/share/perl5/vendor_perl/Term -rw-r--r-- 1 root root 47494 Jul 22 12:41 /usr/share/perl5/vendor_perl/Term/ANSIColor.pm FIX: Remove executable bit from /usr/share/doc/perl-Term-ANSIColor/examples/generate-colors Add 'chmod -c -x examples/*' to %prep section. It also clean up rpmlint warnings 'doc-file-dependency'. Otherwise package looks good. Please correct all `FIX' items and provide new spec file. Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review