[Bug 1119117] Review Request: perl-Algorithm-Cron - Abstract implementation of the cron(8) scheduling algorithm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1119117



--- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
License is ok
URL and Source0 are ok

Summary and Description are ok

Package builds in F22 -
http://koji.fedoraproject.org/koji/taskinfo?taskID=7171971

Build-requires
FIX: Add build-requires 'perl(constant)' - ./lib/Algorithm/Cron.pm:198

$ rpm -qp --provides perl-Algorithm-Cron-0.09-1.fc22.noarch.rpm | sort | uniq
-c
      1 perl(Algorithm::Cron) = 0.09
      1 perl-Algorithm-Cron = 0.09-1.fc22
Binary provides ok

$ rpm -qp --requires perl-Algorithm-Cron-0.09-1.fc22.noarch.rpm | sort | uniq
-c
      1 perl(:MODULE_COMPAT_5.18.2)
      1 perl(Carp)
      1 perl(POSIX)
      2 perl(Time::timegm)
      1 perl(constant)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Remove requires perl(Time::timegm) from spec file, it is found by
     dependency generator.

$ rpmlint perl-Algorithm-Cron*
perl-Algorithm-Cron.src: W: spelling-error %description -l en_US crontab ->
contactable
perl-Algorithm-Cron.src: W: spelling-error %description -l en_US timestamp ->
time stamp, time-stamp, times tamp
perl-Algorithm-Cron.noarch: W: spelling-error %description -l en_US crontab ->
contactable
perl-Algorithm-Cron.noarch: W: spelling-error %description -l en_US timestamp
-> time stamp, time-stamp, times tamp
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
Rpmlint is ok

Otherwise package looks good.

Please correct all `FIX' items and provide new spec file.
Package NOT approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]