[Bug 1115706] Review Request: nodejs-vow-fs - File I/O by Vow

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1115706

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ mock build is successful for f22

+ rpmlint output on rpms gave
nodejs-vow-fs.noarch: W: spelling-error %description -l en_US https -> HTTP
nodejs-vow-fs.noarch: W: spelling-error %description -l en_US github -> git
hub, git-hub, thuggish
nodejs-vow-fs.noarch: W: spelling-error %description -l en_US dfilatov ->
dilator
nodejs-vow-fs.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-vow-fs.noarch: W: only-non-binary-in-usr-lib
nodejs-vow-fs.noarch: W: dangling-symlink
/usr/lib/node_modules/vow-fs/node_modules/node-uuid
/usr/lib/node_modules/node-uuid
nodejs-vow-fs.noarch: W: dangling-symlink
/usr/lib/node_modules/vow-fs/node_modules/vow /usr/lib/node_modules/vow
nodejs-vow-fs.noarch: W: dangling-symlink
/usr/lib/node_modules/vow-fs/node_modules/glob /usr/lib/node_modules/glob
nodejs-vow-fs.noarch: W: dangling-symlink
/usr/lib/node_modules/vow-fs/node_modules/vow-queue
/usr/lib/node_modules/vow-queue
nodejs-vow-fs.src: W: spelling-error %description -l en_US https -> HTTP
nodejs-vow-fs.src: W: spelling-error %description -l en_US github -> git hub,
git-hub, thuggish
nodejs-vow-fs.src: W: spelling-error %description -l en_US dfilatov -> dilator
nodejs-vow-fs.src: W: spelling-error %description -l en_US js -> dis, ks, j
2 packages and 0 specfiles checked; 0 errors, 13 warnings.

=> No issues

+ Source verified with upstream as (sha256sum)
srpm tarball    
:390dafb9663da553a69fb9187b14938132296771f5a056b5bb606b51e6a674ed
upstream tarball
:390dafb9663da553a69fb9187b14938132296771f5a056b5bb606b51e6a674ed

- License tag looks not correct. License tag should be "MIT and GPLv3+"

+ rest looks following packaging guidelines

Suggestions:
1) Fix the license tag


APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]