[Bug 1115709] Review Request: nodejs-w3cjs - A node.js module for using the w3c validator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1115709



--- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ mock build is successful for f22

+ rpmlint output on rpms gave
nodejs-w3cjs.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-w3cjs.noarch: W: spelling-error Summary(en_US) validator -> lavatorial
nodejs-w3cjs.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-w3cjs.noarch: W: spelling-error %description -l en_US url's -> curl's,
purl's, hurl's
nodejs-w3cjs.noarch: W: spelling-error %description -l en_US html -> HTML, ht
ml, ht-ml
nodejs-w3cjs.noarch: W: spelling-error %description -l en_US validator ->
lavatorial
nodejs-w3cjs.noarch: W: only-non-binary-in-usr-lib
nodejs-w3cjs.noarch: W: dangling-symlink
/usr/lib/node_modules/w3cjs/node_modules/argparse
/usr/lib/node_modules/argparse
nodejs-w3cjs.noarch: W: dangling-symlink
/usr/lib/node_modules/w3cjs/node_modules/superagent
/usr/lib/node_modules/superagent
nodejs-w3cjs.noarch: W: dangling-symlink
/usr/lib/node_modules/w3cjs/node_modules/commander
/usr/lib/node_modules/commander
nodejs-w3cjs.noarch: W: dangling-symlink
/usr/lib/node_modules/w3cjs/node_modules/superagent-proxy
/usr/lib/node_modules/superagent-proxy
nodejs-w3cjs.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-w3cjs.src: W: spelling-error Summary(en_US) validator -> lavatorial
nodejs-w3cjs.src: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-w3cjs.src: W: spelling-error %description -l en_US url's -> curl's,
purl's, hurl's
nodejs-w3cjs.src: W: spelling-error %description -l en_US html -> HTML, ht ml,
ht-ml
nodejs-w3cjs.src: W: spelling-error %description -l en_US validator ->
lavatorial
2 packages and 0 specfiles checked; 0 errors, 17 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball    
:cacbfdfa3e8f218279a9f011cf54a58b11de7cd741886fcf97ac067434dd4c7b
upstream tarball
:cacbfdfa3e8f218279a9f011cf54a58b11de7cd741886fcf97ac067434dd4c7b

+ License "Public Domain" is valid and is included in its own file as %doc.

+ rest looks following packaging guidelines


Suggestions:
1) But you need to fix dependencies 
npm(commander)
npm(superagent-proxy)

I think we don't have package npm(superagent-proxy)

Please fix above issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]