https://bugzilla.redhat.com/show_bug.cgi?id=1062942 --- Comment #18 from Jon Ciesla <limburgher@xxxxxxxxx> --- Gotcha: - rpmlint checks return: perl-App-CSV.src: W: strange-permission perl-App-CSV.spec 0600L A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. Trivial, but fix. - package meets naming guidelines - package meets packaging guidelines - license ( MIT ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file So just the spec file perms. Otherwise pretty clean. Any practice reviews you've worked on? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review