https://bugzilla.redhat.com/show_bug.cgi?id=1119087 --- Comment #2 from Sergio Pascual <sergio.pasra@xxxxxxxxx> --- (In reply to Florian "der-flo" Lehner from comment #1) > [!]: If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %doc. > > ---> Please add COPYING to the %files-section There is no COPYING in the tarball. Are you sure you are looking at the correct one? > [!]: Package consistently uses macros (instead of hard-coded directory > names). > > ---> Please replace rm with %{__rm} and cp with %{__install} > This guideline is a about directory names, not command names. If fact, from the guidelines: Macro forms of system executables SHOULD NOT be used except when there is a need to allow the location of those executables to be configurable. For example, rm should be used in preference to %{__rm}, but %{__python} is acceptable. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review