[Bug 1095895] Review Request: rubygem-rubyntlm - Ruby NTLM Authentication Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1095895



--- Comment #1 from Steve Traylen <steve.traylen@xxxxxxx> ---
Hi,

##################################################
Could you update to latest guidelines.

In particualar the 

Requires: ruby(release)
Requires: ruby(rubygems)
Provides: rubygem(%{gem_name}) = %{version}

is not needed for > fc21
##################################################

rubygem(simplecov) is now available so maybe add this
back into the tests.

##################################################
$ rpmlint ../SRPMS/rubygem-rubyntlm-0.4.0-1.fc20.src.rpm 
rubygem-rubyntlm.src: W: strange-permission rubyntlm-0.4.0.gem 0444L

easy enough to clean up.

#################################################

$ rpmlint ../RPMS/noarch/rubygem-rubyntlm-*
rubygem-rubyntlm-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/gems/gems/rubyntlm-0.4.0/examples/smtp.rb
rubygem-rubyntlm-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/gems/gems/rubyntlm-0.4.0/examples/http.rb
rubygem-rubyntlm-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/gems/gems/rubyntlm-0.4.0/examples/imap.rb
rubygem-rubyntlm-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/gems/gems/rubyntlm-0.4.0/README.md
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

#################################################

Other than that all seems good, the licensing is good and clear.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]