[Bug 1119148] Review Request: perl-Daemon-Control - Create init scripts in Perl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1119148



--- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
License is ok
URL and Source0 are ok
Build-requires are ok
Summary and Description are ok

Package builds in F22 -
http://koji.fedoraproject.org/koji/taskinfo?taskID=7171134

$ rpm -qp --provides perl-Daemon-Control-0.001006-1.fc22.noarch.rpm | sort |
uniq -c
      1 perl(Daemon::Control) = 0.001006
      1 perl-Daemon-Control = 0.001006-1.fc22
Binary provides ok

$ rpm -qp --requires perl-Daemon-Control-0.001006-1.fc22.noarch.rpm | sort |
uniq -c
      1 perl >= 0:5.008001
      1 perl(:MODULE_COMPAT_5.18.2)
      2 perl(Cwd)
      1 perl(File::Path)
      1 perl(File::Path) >= 2.08
      2 perl(File::Spec)
      1 perl(POSIX)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1

FIX: remove from Requires perl(Cwd), perl(File::Spec)
TODO: Filter unversioned perl(File::Path) from run-requires

$ rpmlint ./perl-Daemon-Control*
perl-Daemon-Control.noarch: W: spelling-error Summary(en_US) init -> unit, int,
nit
perl-Daemon-Control.noarch: W: spelling-error %description -l en_US init ->
unit, int, nit
perl-Daemon-Control.noarch: W: spelling-error %description -l en_US accessors
-> accessory, accessorizes, accessorize
perl-Daemon-Control.src: W: spelling-error Summary(en_US) init -> unit, int,
nit
perl-Daemon-Control.src: W: spelling-error %description -l en_US init -> unit,
int, nit
perl-Daemon-Control.src: W: spelling-error %description -l en_US accessors ->
accessory, accessorizes, accessorize
2 packages and 1 specfiles checked; 0 errors, 6 warnings.
Rpmlint is ok

Otherwise package looks good.

Please correct all `FIX' items, consider fixing `TODO' items, and provide new
spec file.
Package NOT approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]