[Bug 1118960] Review Request: perl-Clone-PP - Recursively copy Perl data-types

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1118960

Petr Pisar <ppisar@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #7 from Petr Pisar <ppisar@xxxxxxxxxx> ---
URL and Source0 are usable. Ok.
Source archive is original (SHA-256:
4ccf74174a83543787946e5c06a0b3c56f4b3bd29e21632f74d11ade30b9b7e7). Ok.
Summary verified from lib/Clone/PP.pm. Ok.
Description verified from lib/Clone/PP.pm. Ok.
License verified from t/tied.pl, t/dump.pl, t/dclone.t, README,
lib/Clone/PP.pm. Ok.
No XS code, noarch BuildArch is Ok.
All needed build-requires are declared. Ok.

All tests pass. Ok.

$ rpmlint perl-Clone-PP.spec ../SRPMS/perl-Clone-PP-1.06-1.fc22.src.rpm
../RPMS/noarch/perl-Clone-PP-1.06-1.fc22.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Clone-PP-1.06-1.fc22.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Jul 21 12:13
/usr/share/doc/perl-Clone-PP
-rw-r--r--    1 root    root                     1065 Jul 20 21:06
/usr/share/doc/perl-Clone-PP/Changes
-rw-r--r--    1 root    root                     3204 Feb 15 11:09
/usr/share/doc/perl-Clone-PP/README
-rw-r--r--    1 root    root                     3420 Jul 21 12:13
/usr/share/man/man3/Clone::PP.3pm.gz
drwxr-xr-x    2 root    root                        0 Jul 21 12:13
/usr/share/perl5/vendor_perl/Clone
-rw-r--r--    1 root    root                     6138 Jul 18 23:22
/usr/share/perl5/vendor_perl/Clone/PP.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Clone-PP-1.06-1.fc22.noarch.rpm |
sort -f | uniq -c
      1 perl >= 0:5.006
      1 perl(:MODULE_COMPAT_5.18.2)
      1 perl(Exporter)
      1 perl(strict)
      1 perl(vars)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Clone-PP-1.06-1.fc22.noarch.rpm |
sort -f | uniq -c
      1 perl(Clone::PP) = 1.06
      1 perl-Clone-PP = 1.06-1.fc22
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Clone-PP-1.06-1.fc22.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F22
(http://koji.fedoraproject.org/koji/taskinfo?taskID=7171211). Ok.

Package is in line with Fedora and Perl packaging guidelines.

Resolution: Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]