https://bugzilla.redhat.com/show_bug.cgi?id=847420 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-Date-Holidays-DE.spec.old 2012-08-11 03:16:00.000000000 +0200 +++ perl-Date-Holidays-DE.spec 2014-07-19 01:28:06.000000000 +0200 @@ -6,13 +6,14 @@ Summary: Perl module to determine German holidays Name: perl-Date-Holidays-DE Version: 1.6 -Release: 1%{?dist} +Release: 2%{?dist} License: MIT Group: Development/Libraries URL: http://search.cpan.org/dist/%{pkgname}/ Source: http://search.cpan.org/CPAN/authors/id/M/MS/MSCHMITT/%{pkgname}-%{version}.tar.gz Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) BuildRequires: perl(ExtUtils::MakeMaker), perl(Date::Calc) >= 5.0 +BuildRequires: perl(Exporter), perl(Test), perl(Time::Local) BuildArch: noarch BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) @@ -37,7 +38,7 @@ find $RPM_BUILD_ROOT \( -name perllocal.pod -o -name .packlist \) -exec rm -f {} \; chmod -R u+w $RPM_BUILD_ROOT/* -# Don't add dependencies for %doc +# Don't add dependencies for %%doc chmod -x example/*.pl %check @@ -53,6 +54,9 @@ %{perl_vendorlib}/Date/Holidays/ %changelog +* Sat Jul 19 2014 Robert Scheck <robert@xxxxxxxxxxxxxxxxx> 1.6-2 +- Changes to match with Fedora Packaging Guidelines (#847420) + * Sat Aug 11 2012 Robert Scheck <robert@xxxxxxxxxxxxxxxxx> 1.6-1 - Upgrade to 1.6 (#847420) - Initial spec file for Fedora and Red Hat Enterprise Linux > > TODO: Remove explicit %defattr from %files section. > Will not happen because of Fedora EPEL 5 and 6. Not addressed. Were did you get the macro is needed for EPEL5 <https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_Permissions>? > TODO: Build-require `perl(Time::Local)' because the package can dual-live in > the future (DE.pm:7, http://search.cpan.org/~drolsky/Time-Local/). > TODO: Build-require `perl(Exporter)' because the package can dual-live in > the future (DE.pm:13, http://search.cpan.org/~toddr/Exporter/). > TODO: Build-require `perl(Test)' because the package can dual-live in the > future (test.pl:8, http://search.cpan.org/~sburke/Test/). +BuildRequires: perl(Exporter), perl(Test), perl(Time::Local) Ok. > FIX: Escape %doc in the comment with per-cent to prevent from rpm-evaluation. -# Don't add dependencies for %doc +# Don't add dependencies for %%doc Ok. > TODO: Remove the `PREFIX=$RPM_BUILD_ROOT%{_prefix}' argument from > `perl Makefile.PL' command. It's not necessary. Not addressed. $ rpmlint perl-Date-Holidays-DE.spec ../SRPMS/perl-Date-Holidays-DE-1.6-2.fc22.src.rpm ../RPMS/noarch/perl-Date-Holidays-DE-1.6-2.fc22.noarch.rpm perl-Date-Holidays-DE.spec:32: W: rpm-buildroot-usage %build perl Makefile.PL PREFIX=$RPM_BUILD_ROOT%{_prefix} INSTALLDIRS=vendor perl-Date-Holidays-DE.src: W: spelling-error %description -l en_US strftime -> trimmest perl-Date-Holidays-DE.src:32: W: rpm-buildroot-usage %build perl Makefile.PL PREFIX=$RPM_BUILD_ROOT%{_prefix} INSTALLDIRS=vendor perl-Date-Holidays-DE.noarch: W: spelling-error %description -l en_US strftime -> trimmest 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7170924). Ok. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review