[Bug 1076463] Review Request: playitagainsam - Record and replay interactive terminal sessions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1076463



--- Comment #12 from Praveen Kumar <kumarpraveen.nitdgp@xxxxxxxxx> ---
(In reply to Clint Savage from comment #11)
> http://herlo.fedorapeople.org/rpms/playitagainsam-0.3.0-1.fc19.src.rpm
> http://herlo.fedorapeople.org/rpms/playitagainsam.spec

#13 
Source0 can be replaced by
https://pypi.python.org/packages/source/p/%{name}/%{name}-%{version}.tar.gz
using name macro.

#16
Better put each BuildRequire to a new line.

#19
Looks like you put Summary and description same but description should not
contain brief detail about project.

#23
%setup -q -n playitagainsam-%{version} -> %setup -q -n %{name}-%{version},
please use macro as much possible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]