https://bugzilla.redhat.com/show_bug.cgi?id=1117112 --- Comment #5 from greg.hellings@xxxxxxxxx --- Thanks for the review! (and sorry to delay responding - I fell sick just when I had planned to reply) 1. Fix rpmlint issue. -- which, in particular? After the below changes I have the following output from rpmlint: biblesync.src: W: spelling-error %description -l en_US multicast -> Multics, simulcast biblesync.x86_64: W: spelling-error %description -l en_US multicast -> Multics, simulcast biblesync-devel.x86_64: W: only-non-binary-in-usr-lib 4 packages and 0 specfiles checked; 0 errors, 3 warnings. 2. %description wrapped too much, 79 chars per line, you use too many lines here. -- Fixed 3. -devel: I strongly advise that putting Summary on top of the Requires. -- Done 4. -devel: Requires: biblesync = %{version} Requires: libuuid-devel See: https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package -- Corrected 5. %doc biblesync-v1.png Rationale? -- I was building off of the suggestions of the upstream packager. I have removed this from the package 6. For main lib package, a license file is _enough_. You should put the rest to the -devel. -- Done 7. %{_mandir}/man7/biblesync.7.gz Should be put into -devel, too. -- Done I'll upload the new spec as-is or I can update to fix that rpmlint warning if you want me to look into it. Again, sorry for the delay. If you've got any reviews of your own waiting, point me to them and I'll be happy to swap. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review