https://bugzilla.redhat.com/show_bug.cgi?id=1096184 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review: + mock build is successful for f22 - rpmlint output on rpms gave nodejs-i18n-transform.noarch: W: spelling-error Summary(en_US) json -> son, j son nodejs-i18n-transform.noarch: W: summary-not-capitalized C i18n transforms to a json object. nodejs-i18n-transform.noarch: W: summary-ended-with-dot C i18n transforms to a json object. nodejs-i18n-transform.noarch: W: spelling-error %description -l en_US json -> son, j son nodejs-i18n-transform.noarch: W: only-non-binary-in-usr-lib nodejs-i18n-transform.src: W: spelling-error Summary(en_US) json -> son, j son nodejs-i18n-transform.src: W: summary-not-capitalized C i18n transforms to a json object. nodejs-i18n-transform.src: W: summary-ended-with-dot C i18n transforms to a json object. nodejs-i18n-transform.src: W: spelling-error %description -l en_US json -> son, j son 2 packages and 0 specfiles checked; 0 errors, 9 warnings. ==> Fix the summary related warnings + Source verified with upstream as (sha256sum) srpm tarball :78bd08a2aa061fe6dd8ab087a9e7ac59b61a8ce155055ddd0eb89a031e95307a upstream tarball :78bd08a2aa061fe6dd8ab087a9e7ac59b61a8ce155055ddd0eb89a031e95307a + License "MIT" is valid and is included in its own file as %doc + rest looks following packaging guidelines Suggestions: 1) you can drop Group tag for Fedora releases. 2) Package is missing Requires: npm(hoek) 3) we don't have updated nodejs-hoek in Fedora so need to fix its version. Use in %prep %nodejs_fixdep hoek 4) %check should be added as before %files as %check %if 0%{?enable_tests} grunt test %endif -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review