[Bug 1107800] Review Request: dl_poly - General purpose classical molecular dynamics (MD) simulation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1107800



--- Comment #2 from Orion Poplawski <orion@xxxxxxxxxxxxx> ---
The spec in the url is different from the src.rpm.  Please sync up.

Take a look at the java guidelines, you're missing some stuff there (requries
jpackage-utils, 

- Large documentation must go in a -doc subpackage. Large could be size (~1MB)
  or number of files.
  Note: Documentation size is 3143680 bytes in 7 files.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation

- drop %defattr()

- Are you targeting EL5?  If not, you can also drop %clean and the rm -rf
$RPM_BUILD_ROOT in %install

- I would consistently use the %{} form of macros for file paths.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]