https://bugzilla.redhat.com/show_bug.cgi?id=1120293 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #7 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: $ diff -u perl-Inline-C.spec{.old,} --- perl-Inline-C.spec.old 2014-07-17 15:13:52.000000000 +0200 +++ perl-Inline-C.spec 2014-07-17 16:24:15.000000000 +0200 @@ -6,10 +6,10 @@ Group: Development/Libraries URL: http://search.cpan.org/dist/Inline-C/ # Created from http://www.cpan.org/authors/id/I/IN/INGY/Inline-C-%{version}.tar.gz -# tar xzf Inline-C-%{version}.tar.gz && \ -# rm -f Inline-C-%{version}/lib/Inline/C/Cookbook.pod && \ -# sed -e '/Cookbook.pod$/d' -i Inline-C-%{version}/MANIFEST && \ -# tar czf Inline-C-%{version}.fedora.tar.gz Inline-C-%{version} +# tar xzf Inline-C-%%{version}.tar.gz && \ +# rm -f Inline-C-%%{version}/lib/Inline/C/Cookbook.pod && \ +# sed -e '/Cookbook.pod$/d' -i Inline-C-%%{version}/MANIFEST && \ +# tar czf Inline-C-%%{version}.fedora.tar.gz Inline-C-%{version} Source0: Inline-C-%{version}.fedora.tar.gz BuildArch: noarch BuildRequires: perl @@ -19,7 +19,7 @@ BuildRequires: perl(Cwd) BuildRequires: perl(Data::Dumper) BuildRequires: perl(diagnostics) -BuildRequires: perl(ExtUtils::MakeMaker) >= 6.30 +BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 BuildRequires: perl(Fcntl) BuildRequires: perl(File::Path) BuildRequires: perl(File::Spec) @@ -34,6 +34,7 @@ BuildRequires: perl(Test::Warn) BuildRequires: perl(Time::HiRes) BuildRequires: perl(warnings) +Requires: perl(FindBin) Requires: perl(Inline) >= 0.58 Requires: perl(:MODULE_COMPAT_%(eval "$(perl -V:version)"; echo $version)) # Split from Inline in 0.58 > TODO: Due to NO_PACKLIST=1 added in recent ExtUtil::MakeMaker, you should > increase perl(ExtUtils::MakeMaker) build-time dependency to `>= 6.76'. -BuildRequires: perl(ExtUtils::MakeMaker) >= 6.30 +BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 Ok. > TODO: Constrain `perl(File::Spec)' dependency with `>= 0.8' (Makefile.PL:23). Not addressed. > TODO: Constrain `perl(Parse::RecDescent)' dependency with `>= 1.80' > (Makefile.PL:25). Not addressed. > TODO: Constrain `perl(Test::More)' dependency with `>= 0.88' (Makefile.PL:45). Not addressed. > TODO: Constrain `perl(Test::Warn)' dependency with `>= 0.23' (Makefile.PL:46). Not addressed. > TODO: I recommend to conditionalize dependencies on Inline::Filters and > Inline::Struct by %perl_bootstrap macro as they are optional as > Parse::RecDescent. Not addressed. One can add %global perl_bootstrap 1 at the beginning of the spec file now and use the macros now. $ rpmlint perl-Inline-C.spec ../SRPMS/perl-Inline-C-0.60-1.fc22.src.rpm ../RPMS/noarch/perl-Inline-C-0.60-1.fc22.noarch.rpm perl-Inline-C.spec:8: W: macro-in-comment %{version} perl-Inline-C.spec:12: W: macro-in-comment %{version} perl-Inline-C.spec: W: invalid-url Source0: Inline-C-0.60.fedora.tar.gz perl-Inline-C.src:8: W: macro-in-comment %{version} perl-Inline-C.src:12: W: macro-in-comment %{version} perl-Inline-C.src: W: invalid-url Source0: Inline-C-0.60.fedora.tar.gz 2 packages and 1 specfiles checked; 0 errors, 6 warnings. > TODO: Remove under-specified dependency on `perl(Inline) >= 0.56'. Not addressed. $ rpm -q --requires -p ../RPMS/noarch/perl-Inline-C-0.60-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(Carp) 1 perl(Config) 1 perl(Cwd) 1 perl(Data::Dumper) 1 perl(ExtUtils::MakeMaker) 1 perl(Fcntl) 1 perl(File::Spec) 1 perl(FindBin) 1 perl(Inline) >= 0.56 1 perl(Inline) >= 0.58 1 perl(strict) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 > TODO: Remove under-specified dependency on `perl(Inline) >= 0.56'. Not addressed. > FIX: Run-require `perl(FindBin)' (lib/Inline/C.pm:47). Ok. > TODO: I recommend to run-require Inline::Filters, Inline::Struct, > Parse::RecDescent, Time::HiRes. The code croaks without them. This is just a > prettier die. Not addressed. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7158611). Ok. Please consider fixing the `TODO' items before building the package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review