https://bugzilla.redhat.com/show_bug.cgi?id=1120293 --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source tar ball is modified (original SHA-256: f8593750d45d1c068195b4f16643fe4b3d50956e79d26c3c8aa7ba887ae75a45). lib/Inline/C/Cookbook.pod has been removed and MANIFEST updated. Ok. Summary verified from README. Ok. Description verified from README. Ok. License verified from lib/Inline/C.pod, lib/Inline/C/ParseRecDescent.pod, lib/Inline/C/ParseRegExp.pod, LICENSE, README. Ok. No XS is code in the binary packages, noarch BuildArch is Ok. TODO: Due to NO_PACKLIST=1 added in recent ExtUtil::MakeMaker, you should increase perl(ExtUtils::MakeMaker) build-time dependency to `>= 6.76'. The Concflicts is Ok. TODO: Constrain `perl(File::Spec)' dependency with `>= 0.8' (Makefile.PL:23). TODO: Constrain `perl(Parse::RecDescent)' dependency with `>= 1.80' (Makefile.PL:25). TODO: Constrain `perl(Test::More)' dependency with `>= 0.88' (Makefile.PL:45). TODO: Constrain `perl(Test::Warn)' dependency with `>= 0.23' (Makefile.PL:46). TODO: I recommend to conditionalize dependencies on Inline::Filters and Inline::Struct by %perl_bootstrap macro as they are optional as Parse::RecDescent. Test::Pod is not used. Ok. All tests pass. Ok. $ rpmlint perl-Inline-C.spec ../SRPMS/perl-Inline-C-0.60-1.fc22.src.rpm ../RPMS/noarch/perl-Inline-C-0.60-1.fc22.noarch.rpm perl-Inline-C.spec:8: W: macro-in-comment %{version} perl-Inline-C.spec:9: W: macro-in-comment %{version} perl-Inline-C.spec:10: W: macro-in-comment %{version} perl-Inline-C.spec:11: W: macro-in-comment %{version} perl-Inline-C.spec:12: W: macro-in-comment %{version} perl-Inline-C.spec:12: W: macro-in-comment %{version} perl-Inline-C.spec: W: invalid-url Source0: Inline-C-0.60.fedora.tar.gz perl-Inline-C.src:8: W: macro-in-comment %{version} perl-Inline-C.src:9: W: macro-in-comment %{version} perl-Inline-C.src:10: W: macro-in-comment %{version} perl-Inline-C.src:11: W: macro-in-comment %{version} perl-Inline-C.src:12: W: macro-in-comment %{version} perl-Inline-C.src:12: W: macro-in-comment %{version} perl-Inline-C.src: W: invalid-url Source0: Inline-C-0.60.fedora.tar.gz 2 packages and 1 specfiles checked; 0 errors, 14 warnings. TODO: Escape % in comments. $ rpm -q -lv -p ../RPMS/noarch/perl-Inline-C-0.60-1.fc22.noarch.rpm drwxr-xr-x 2 root root 0 Jul 17 15:50 /usr/share/doc/perl-Inline-C -rw-r--r-- 1 root root 1267 Jul 14 07:04 /usr/share/doc/perl-Inline-C/CONTRIBUTING -rw-r--r-- 1 root root 5435 Jul 14 07:04 /usr/share/doc/perl-Inline-C/Changes -rw-r--r-- 1 root root 18350 Jul 14 07:04 /usr/share/doc/perl-Inline-C/LICENSE -rw-r--r-- 1 root root 19756 Jul 14 07:04 /usr/share/doc/perl-Inline-C/README -rw-r--r-- 1 root root 9345 Jul 17 15:48 /usr/share/man/man3/Inline::C.3pm.gz -rw-r--r-- 1 root root 2159 Jul 17 15:48 /usr/share/man/man3/Inline::C::ParseRecDescent.3pm.gz -rw-r--r-- 1 root root 2159 Jul 17 15:48 /usr/share/man/man3/Inline::C::ParseRegExp.3pm.gz drwxr-xr-x 2 root root 0 Jul 17 15:48 /usr/share/perl5/vendor_perl/Inline/C -rw-r--r-- 1 root root 33308 Jul 14 07:04 /usr/share/perl5/vendor_perl/Inline/C.pm -rw-r--r-- 1 root root 19197 Jul 14 07:04 /usr/share/perl5/vendor_perl/Inline/C.pod -rw-r--r-- 1 root root 4122 Jul 14 07:04 /usr/share/perl5/vendor_perl/Inline/C/ParseRecDescent.pm -rw-r--r-- 1 root root 775 Jul 14 07:04 /usr/share/perl5/vendor_perl/Inline/C/ParseRecDescent.pod -rw-r--r-- 1 root root 5576 Jul 14 07:04 /usr/share/perl5/vendor_perl/Inline/C/ParseRegExp.pm -rw-r--r-- 1 root root 743 Jul 14 07:04 /usr/share/perl5/vendor_perl/Inline/C/ParseRegExp.pod File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Inline-C-0.60-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(Carp) 1 perl(Config) 1 perl(Cwd) 1 perl(Data::Dumper) 1 perl(ExtUtils::MakeMaker) 1 perl(Fcntl) 1 perl(File::Spec) 1 perl(Inline) >= 0.56 1 perl(Inline) >= 0.58 1 perl(strict) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 TODO: Remove under-specified dependency on `perl(Inline) >= 0.56'. FIX: Run-require `perl(FindBin)' (lib/Inline/C.pm:47). TODO: I recommend to run-require Inline::Filters, Inline::Struct, Parse::RecDescent, Time::HiRes. The code croaks without them. This is just a prettier die. $ rpm -q --provides -p ../RPMS/noarch/perl-Inline-C-0.60-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(Inline::C) = 0.60 1 perl(Inline::C::ParseRecDescent) 1 perl(Inline::C::ParseRegExp) 1 perl-Inline-C = 0.60-1.fc22 Binary provides are Ok. resolvedeps f22-build ../RPMS/noarch/perl-Inline-C-0.60-1.fc22.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7158331). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items, consider fixing `TODO' items, and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review