[Bug 1120366] Review Request: nodejs-set-immediate - A shim for the setImmediate API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1120366

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ mock build is successful for f22

+ rpmlint output on rpms gave
nodejs-set-immediate.noarch: W: spelling-error Summary(en_US) setImmediate ->
set Immediate, set-immediate, immediateness
nodejs-set-immediate.noarch: W: spelling-error %description -l en_US
setImmediate -> set Immediate, set-immediate, immediateness
nodejs-set-immediate.noarch: W: only-non-binary-in-usr-lib
nodejs-set-immediate.src: W: spelling-error Summary(en_US) setImmediate -> set
Immediate, set-immediate, immediateness
nodejs-set-immediate.src: W: spelling-error %description -l en_US setImmediate
-> set Immediate, set-immediate, immediateness
2 packages and 0 specfiles checked; 0 errors, 5 warnings.

==> Not a issue

+ Source verified with upstream as (sha256sum)
srpm tarball    
:f30ca71c7b81a9d32163e09cd1aa40d83f7772c6de9f416d3a9d374419dda4d2
upstream tarball
:f30ca71c7b81a9d32163e09cd1aa40d83f7772c6de9f416d3a9d374419dda4d2

+ License "MIT" is valid and included in separate text file as patch

+ rest looks Ok

Suggestion:
1) cp command in %prep should preserve timestamp though its not a upstream
file.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]