https://bugzilla.redhat.com/show_bug.cgi?id=1116487 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: $ diff -u perl-App-DuckDuckGo.spec{.old,} --- perl-App-DuckDuckGo.spec.old 2014-07-10 08:49:22.000000000 +0200 +++ perl-App-DuckDuckGo.spec 2014-07-17 09:18:39.000000000 +0200 @@ -13,7 +13,6 @@ BuildRequires: perl(MooseX::Getopt) >= 0.35 BuildRequires: perl(strict) BuildRequires: perl(Test::More) >= 0.90 -BuildRequires: perl(Test::Pod) BuildRequires: perl(WWW::DuckDuckGo) >= 0.004 BuildRequires: perl(warnings) Requires: perl(Moose) >= 1.24 @@ -31,6 +30,7 @@ %prep %setup -q -n App-DuckDuckGo-%{version} +sed -i 's|#!/usr/bin/env perl|#!%{__perl}|' bin/duckduckgo %build %{__perl} Makefile.PL INSTALLDIRS=vendor @@ -60,7 +60,7 @@ shell script to automatically work with the DuckDuckGo API results. %files -n duckduckgo -%doc README +%doc LICENSE README %{_mandir}/man1/* %{_bindir}/* > TODO: I recommend to package the LICENSE file into duckduckgo sub-package too. > Because is does not run-require a specific version of the main package, it can > happen an user gets installed different versions of the the sub-packages which > can differ in the license. (If upstream decides to change the license). %files -n duckduckgo -%doc README +%doc LICENSE README Ok. > FIX: Do not build-require `perl(Test::Pod)' as the module is never used > (t/release-pod-syntax.t:4). -BuildRequires: perl(Test::Pod) Ok. > TODO: The /usr/bin/env scripts interpreter is considered harmful by some > packageres. It would be nice to replace it with `#!%{_perl}' (or `#!perl' > which ExtUtils::MakeMaker fixes automatically). +sed -i 's|#!/usr/bin/env perl|#!%{__perl}|' bin/duckduckgo Ok. $ rpmlint perl-App-DuckDuckGo.spec ../SRPMS/perl-App-DuckDuckGo-0.008-1.fc22.src.rpm ../RPMS/noarch/perl-App-DuckDuckGo-0.008-1.fc22.noarch.rpm ../RPMS/noarch/duckduckgo-0.008-1.fc22.noarch.rpm duckduckgo.noarch: W: name-repeated-in-summary C DuckDuckGo 3 packages and 1 specfiles checked; 0 errors, 1 warnings. rpmlint is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-App-DuckDuckGo-0.008-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(Moose) >= 1.24 1 perl(MooseX::Getopt) >= 0.35 1 perl(WWW::DuckDuckGo) >= 0.004 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm -q --requires -p ../RPMS/noarch/duckduckgo-0.008-1.fc22.noarch.rpm | sort -f | uniq -c 1 /usr/bin/perl 1 perl(App::DuckDuckGo) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-App-DuckDuckGo-0.008-1.fc22.noarch.rpm ../RPMS/noarch/duckduckgo-0.008-1.fc22.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7155754). Ok. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review