[Bug 1116487] Review Request: perl-App-DuckDuckGo - Application to query DuckDuckGo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1116487



--- Comment #3 from David Dick <ddick@xxxxxxxx> ---
(In reply to Petr Pisar from comment #2)
> TODO: I recommend to package the LICENSE file into duckduckgo sub-package
> too. Because is does not run-require a specific version of the main package,
> it can happen an user gets installed different versions of the the
> sub-packages which can differ in the license. (If upstream decides to change
> the license).

Done.

> FIX: Do not build-require `perl(Test::Pod)' as the module is never used
> (t/release-pod-syntax.t:4).

Removed.

> TODO: The /usr/bin/env scripts interpreter is considered harmful by some
> packageres. It would be nice to replace it with `#!%{_perl}' (or `#!perl'
> which ExtUtils::MakeMaker fixes automatically).

Fixed with a sed script in %setup

Spec and SRPM have been uploaded again.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]