[Bug 1119369] Review Request: speedtest-cli - Command line interface for testing internet bandwidth

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1119369



--- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
first I will suggest some changes here

1) This package does not do any compilations. This is a noarch package so just
add
BuildArch: noarch

2) Then you will not needed any compilation flags to be set so remove 
CFLAGS="$RPM_OPT_FLAGS" from both the lines

3) For Fedora and EPEL6/EPEL7 you will not need to remove buildroot in %install
drop following line
rm -rf %{buildroot}

See https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

4) another thing I found Pypi already hosts this package source but did not
include man page or modified the upstream tarball so don't use that keep the
github source only.

5) I see both the binaries are same speedtest and speedtest-cli. Check with
upstream to fix this and provide only speedtest-cli. In the spec file you can
add to %install
rm -f $RPM_BUILD_ROOT%{_bindir}/speedtest

6) Decide first if you want python3 package as well or not?

7) you may want to install man page manually as by adding to %install
gzip speedtest-cli.1
mkdir -p $RPM_BUILD_ROOT%{_mandir}/man1
install -p -m 644 speedtest-cli.1.gz
$RPM_BUILD_ROOT%{_mandir}/man1/speedtest-cli.1.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]