[Bug 1115894] Review Request: ghc-hgettext - Bindings to libintl.h (gettext, bindtextdomain)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1115894



--- Comment #4 from Jens Petersen <petersen@xxxxxxxxxx> ---
(In reply to Philip Withnall from comment #3)
> > There is no License file included in the tarball.
> > Can you please contact the author about adding one upstream?
> 
> https://github.com/vasylp/hgettext/issues/5

Thanks!

> > What is /usr/bin/hgettext for?  Probably it should live
> > in ghc-hgettext-devel not ghc-hgettext, since it looks like
> > a devel tool not something needed at runtime.
> 
> I was treating it the same as /usr/bin/gettext which comes from the gettext
> package, rather than gettext-devel.

I see.  /usr/bin/gettext can be used by shell scripts at runtime.
I am not sure about the use case for /usr/bin/hgettext.
Is it used by project maintainers for extracting strings
to be translated or are you saying it could be used at runtime?

If it is the former kind of tool then I think it should really
live in ghc-hgettext-devel, since consumer packages of hgettext
would just use libHShgettext.

> > I think a better package Summary might be "Haskell binding to libintl".
> 
> Done.

Thanks

> If you're OK with the hgettext binary remaining in the non-devel package,
> I'll request a git repo and start turning the fedpkg wheel (with the summary
> change and no licence file). Otherwise I can do another iteration of the
> spec file here with more Koji scratch builds.

Given there are few changes it would be nice to see
the final packaging here I feel.  I can approve once that is done:
so you probably don't need to do all the scratch builds again.
Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]