https://bugzilla.redhat.com/show_bug.cgi?id=1116021 František Dvořák <valtri@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |valtri@xxxxxxxxxx --- Comment #1 from František Dvořák <valtri@xxxxxxxxxx> --- Some comments from me (although I'm not experienced ruby packager): * license: it is rather "BSD" than "MIT" rubygems.org refers to MIT, but the LICENSE file and .gemspec file contains BSD (2-clause). Were is source of the license for rubygems.org? (maybe upstream could be notified?) * rake is not recommended for launching the tests Rake is not typically used in Fedora to execute test suite, since it almost always needs some additional unnecessary dependencies. I were lucky to launch tests this way: mkdir tmp ruby -Ilib:%{buildroot}%{gem_extdir_mri}/lib:test -e 'Dir.glob "./test/**/*_test.rb", &method(:require)' ==> rake-compiler would not be needed then, although I think there is required rubygem(test-unit) BR? * %{buildroot}%{gem_instdir}/lib/ruby_prof.so doesn't exists (package can't be built in rawhide) I think the move command should look like this?: mv %{buildroot}%{gem_instdir}/ext/ruby_prof/ruby_prof.so %{buildroot}%{gem_extdir_mri}/lib/ * E: non-standard-executable-perm /usr/lib64/gems/ruby/ruby-prof-0.15.1/lib/ruby_prof.so 0775L Permissions of %{gem_extdir_mri}/lib/ruby_prof.so should be rather 0755 then 0775. * W: no-manual-page-for-binary ruby-prof, ruby-prof-check-trace It is recommended to work with upstream to create man-pages, or to check Debian: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=PackagingGuidelines#Man_pages * other issues seems OK or false positives: - dir ownership in debuginfo - doc subpackage dependency OK (it's noarch) - bundled font files OK (rdoc generated) - here is described porting to minitest 5: https://lists.fedoraproject.org/pipermail/ruby-sig/2014-June/001594.html, I've tried some porting and were lucky with that, but the patch seems quite aggressive and '%check' will be needed disabled anyway on some branches... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review