https://bugzilla.redhat.com/show_bug.cgi?id=977646 David Dick <ddick@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #12 from David Dick <ddick@xxxxxxxx> --- (In reply to Christopher Meng from comment #11) > I delete the pm files (because they are configuration files, I personally > don't want users to lost them during the transaction), therefore just empty > the folder and add the folder in the %files while placing hooks underneath > the %_pkgdocdir. Okay. I've missed one more BR which you'll need to add to pass syntaxcheck BR perl(File::Copy::Recursive) Also, the license appears to be GPLv2+ (see mylvmbackup line 7-8) Sorry for missing these points on my first review. -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review