Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-tag - Python bindings for TagLib to read and write music files tags https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228303 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|normal |medium lxtnow@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? ------- Additional Comments From lxtnow@xxxxxxxxx 2007-04-18 22:08 EST ------- OK - Mock : Built on FC6 en FC-Devel (i386 and x86_64) OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License field in spec matches OK - License is BSD (BSD_like) NO - License file is not included in package ----- The BSD license is only mentioned by PKG-INFO file which is not included in the package. ----- OK - Spec in American English OK - Spec is legible. OK - Sources SHOULD match upstream md5sum: c9de0b7b3819579b5f460b20c42e03c9 tagpy-0.91.tar.gz OK - Package has correct buildroot. OK - BuildRequires isn't redundant. OK - %build and %install stages is correct and work. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Changelog section is correct. OK - Should function as described. OK - Should package latest version ------------------------------------------------ Rpmlint output: ------------------------------------------------ * from srpm : quiet. * from rpm : W: python-tag spurious-executable-perm /usr/share/doc/python-tag-0.91/tagrename W: python-tag doc-file-dependency /usr/share/doc/python-tag-0.91/tagrename /usr/bin/env The files which are installed in %{_docdir}/%{name}-%{version} are exemples, as mentioned in the README file which's includes in the package. So, these errors are harmless and can be IGNORED. But, maybe you could change the default permission on it to make rpmlint cute :-). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review