https://bugzilla.redhat.com/show_bug.cgi?id=1119095 Jamie Duncan <jduncan@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jduncan@xxxxxxxxxx --- Comment #1 from Jamie Duncan <jduncan@xxxxxxxxxx> --- A 'non-official' review. rpmlint is totally clean: Checking: python-djvulibre-0.3.9-1.fc20.x86_64.rpm python-djvulibre-0.3.9-1.fc20.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. BuildRoot Tag: this is only required for EPEL 5 and older. might want to wrap that around some logic. http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag Python Macros: These should probably be updated to %{__python2}, etc. http://fedoraproject.org/wiki/Packaging:Python#Macros BuildRequires: Need to add python2-devel, etc. so it builds properly in the build system. You're listing python-devel, but that may get confusing down the road when Py3 becomes the default. http://fedoraproject.org/wiki/Packaging:Python#BuildRequires defattr at top of %files: This isn't required anymore. http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions The module itself imports cleanly. Other than picking those nits, it looks good. Welcome to Fedora! Cheers, Jamie Duncan -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review