https://bugzilla.redhat.com/show_bug.cgi?id=1105015 --- Comment #4 from Dan Callaghan <dcallagh@xxxxxxxxxx> --- (In reply to Jeff Backus from comment #3) > Good point. Also, unfortunately, I seem to have given you erroneous advice. > cp -p copies all permissions, so now I'm getting a rpmlint error. The > correct method is to use install -p. I verified that this is correct. Please > change destdir.patch to either use install -p or to not use cp -p on line > 12. Sorry about that! Oops. Fixed: http://fedorapeople.org/~dcallagh/lua-ldap/lua-ldap.spec http://fedorapeople.org/~dcallagh/lua-ldap/lua-ldap-1.1.0-3.fc22.src.rpm > Since this package hasn't been built by the system, increasing the version > number is optional. Please see the section on multiple Changelog Entries per > Release in the guidelines for more information. > https://fedoraproject.org/wiki/Packaging: > Guidelines#Multiple_Changelog_Entries_per_Release I prefer to bump the RPM release number each time I publish a new SRPM on the review, even though it's not built in Koji yet. It makes it possible for someone who comes along and looks at the review after the fact to fetch each different version of the SRPM and see what changed each time. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review