https://bugzilla.redhat.com/show_bug.cgi?id=977646 --- Comment #9 from David Dick <ddick@xxxxxxxx> --- Please add the following BR perl(lib) BR perl(MIME::Lite) BR perl(Config::IniFiles) BR perl(Date::Format) BR perl(DBD::mysql) BR perl(DBI) BR perl(diagnostics) BR perl(Fcntl) BR perl(File::Basename) BR perl(File::Copy) BR perl(File::Path) BR perl(File::Temp) BR perl(Getopt::Long) BR perl(strict) BR perl(Sys::Hostname) BR perl(Sys::Syslog) Also, while upstream has provided no tests to allow us to check the package works as expected on different archs, if you add a basic check section, such as %check perl -c %{name} that will help with ensuring the binary will at least compile correctly. If you add %dir %{_datadir}/%{name} to %files and mkdir -p %{buildroot}%{_datadir}/%{name} to the end of the %install section, that will provide a directory for users to place their own hooks. i will continue this review tomorrow. -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review